Migrate JSON configs to YAML

[gomorizsolt]

Issue #91.

[thisismydesign]

I'm wondering if it's a good idea to read the config from yml all the time. How about a wrapper that reads it once?

[gomorizsolt]

Please take a look at the changes. I've created a top-level context that's responsible for reading the file once and expose it to its child components. I don't think it's required to use memoization though.

[gomorizsolt]

I don't think it's required to use memoization though.

Yea, I've rather removed useMemo().

[gomorizsolt]

Tasks that have yet to be done to make the PR ready for review:

• Document CONFIG_JSON environment variable for automated deployments #102 (comment) ("Deployment" chapter " + rename the environment variable)
• remove the "Configuration" chapter from README.md

[gomorizsolt]

This error pops up for some reason. AFAICT it originates from the <Medium /> component. I'll look into it.

[gomorizsolt]

#106 (comment) => fc9d9e7

It'd be great to make it less error-prone though, i.e. the / at the end of the URL might not be added.

const slashRequired = proxy[proxy.length -1] === "/";
const feedUrl = `${proxy}{${slashRequired} ? "/" : ""}https://medium.com/feed/${username}`;

How about something like the above? Or let's just mention it somewhere in the doc.

[thisismydesign]

It'd be great to make it less error-prone though, i.e. the / at the end of the URL might not be added.

The proper way of dealing with this is through a library that can parse and construct URLs/URIs. They should have a method for adding paths.

[gomorizsolt]

It'd be great to make it less error-prone though, i.e. the / at the end of the URL might not be added.

The proper way of dealing with this is through a library that can parse and construct URLs/URIs. They should have a method for adding paths.

Gotcha, thanks.

dotdev/src/components/Medium/utils/MediumUtils.js

Lines 6 to 12 in de0369f

	const proxify = (proxy, url) => {
	const proxifiedUrl = new Url(proxy);
	proxifiedUrl.set("pathname", url);
	return proxifiedUrl.toString();
	};

.