Implement configuration via container extensions

[ghost]

This means you can configure the bundle settings without extending
the base controller class.

For example: you can add these settings to your config.yml file

c33s_static_pages:
    content_bundle: MyBundle
    content_dir:    Pages

You can either look at the Configuration class or run
app/console config:dump-reference c33s_static_pages (after pulling) to see
a list of all current configuration parameters.

[ghost]

I think that the controller class should be renamed after this is merged. It's not really a base controller anymore.

[vworldat]

This change does not allow for several bundles to hold static content at the same time. For me this is a dealbraker. I want to be able to:

• have content in several bundles/controllers
• use different "settings" (e.g. base template) depending on the controller being used

This is easily possible at the moment, but not with your changes. What about changing the config to something like this:

c33s_static_pages:
    My\Bundle\Controller\MyController:
        content_dir:    Pages
        wrapper_template: something
        # ...
    My\Bundle\Controller\OtherController:
        content_dir:    Stuff
        wrapper_template: something
        # ...
    My\OtherBundle\Controller\MyController:
        content_dir:    Sites
        wrapper_template: something
        # ...

Not that I want to change these settings all the time, but I need to have various configurations at the same time.

Edit: this would again require separate controllers, I will think of something else. Not quite woken up yet ;-)

[ghost]

ah that was next on my list. i didn't realize this bundle was that popular to get a comment so quickly.

[vworldat]

One more thing: please do not remove those calls. They are extremely important for cases in which the class is extended. Why not just let the getTemplateExtension() method return the container-getParameter() call?

[ghost]

@vworldat that's exactly what i just did, since i think the work of making the configuration parser recursive deserves it's own pull request. I figured i'd implement that later.

However.. I am against having a bloated controller. the way you suggested before is a more correct way of doing it. I definitely don't wanna have a bunch of configurable methods in a controller.

I was planning on moving all that configurable stuff out to a template locator service.

[ghost]

@c33s : i kept compatibility with the current controller methods as suggested by @vworldat . This should be mergeable now and it doesn't even break BC

[vworldat]

Well, actually a dedicated service to handle configuration / templates / etc would be great. I just don't have any idea yet, how this can be combined with the routing configuration. Using templates from several locations under several URLs might lead to something like this:

#routing.yml

some_bundle_webpage_static:
    pattern:  /some/path/{name}
    defaults: { _controller: "SomeWebpageBundle:StaticPage:show" }
    requirements:
        name:  .*

my_bundle_webpage_static:
    pattern:  /{name}
    defaults: { _controller: "MyWebpageBundle:StaticPage:show" }
    requirements:
        name:  .*

This also is how it is currently used by me and @c33s (we were both involved in the basic development of the package).

[ghost]

sorry for all the churn.. this should be good to go now.

[ghost]

@vworldat, @c33s : are either of you on freenode irc? if you got a minute we could discuss how to handle that usecase there.

[vworldat]

Please give me 30 to 45 minutes, then I'll be able to join. Which channel?

[ghost]

I think that's a bit soon for me. I'm going to bed soon, and we could probably end up talking for awhile.

I'll just think a bit longer and then try to meet up soon.

Hopefully the PR is good to go now?

[ghost]

i guess the only thing that should be changed is maybe c33s_static_pages: to c33s_static_content.

If it's ok other than that.. then please say so. so i can start using it in my own fork until you folks actually merge it.

[vworldat]

Since this is work in progress anyway, I think we can just leave it at that for now.