Extract code from cli.main into shorter methods #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love to see this go in, the current main function is unnecessarily hard to get to grips with, which is holding up progress on other issues. |
|
It's definitely an improvement, although I've found that doing heavy modification of the command-line arguments is still... quite painful :-) Maintainers, can this be considered for merging? Anything that needs to be done differently? |
ekohl
reviewed
Jun 7, 2019
Pylint config: see c4urself#67
Also avoid reading the file twice.
(arguments which are modified in-place instead of copied/modified/returned)
These used to come along with installing tox, but this is no longer the case since version 3.10. See similar fix h5py/h5py@b183c74 and tox issue tox-dev/tox#1304 .
|
This is now rebased on master + I have applied all the suggestions. |
This got lost in the recent rebase.
ekohl
reviewed
Jun 14, 2019
Similar to its class VersionConfig.
Versus context and vcs_context.
Handle the None case in VersionConfig.parse.
|
With this update, the branch conforms to all remarks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not change any functionality, but it makes main() much shorter and at least
helps to decode what's going on.
Done as a preparation for implementing #57, which has impact on argument parsing.
I've made sure that
cli.pysatisfiespylintsimilar to what's done in #67.Merging this with
#67would give merge conflicts, but this way it does not require manual resolution.