Merge pull request #4429 from dippindots/fix-9902

Always show label for pie chart when ratio is larger than 0.25
cBioPortal · Nov 28, 2022 · 65ea8ca · 65ea8ca
2 parents 9cf03e9 + b01ef33
commit 65ea8ca
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/...te/screenshots/reference/tcga_pancancer_atlas_page_element_chrome_1600x1000.png b/...te/screenshots/reference/tcga_pancancer_atlas_page_element_chrome_1600x1000.png
diff --git a/src/pages/studyView/charts/pieChart/PieChart.tsx b/src/pages/studyView/charts/pieChart/PieChart.tsx
@@ -189,7 +189,10 @@ export default class PieChart extends React.Component<IPieChartProps, {}>
 
     @autobind
     private label(d: ClinicalDataCountSummary) {
-        return d.count / this.totalCount > 0.5
+        // Always show label when ratio of pie is larger than 0.25
+        // If ratio of pie is less than 0.25, do check the max length we can show the text and the text length
+        // to decide if we should show the label or not
+        return d.count / this.totalCount > 0.25
             ? d.count.toLocaleString()
             : this.maxLength(
                   d.count / this.totalCount,