-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group comparison: update group exclusion message #3709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean!
@kalletlak could you elaborate what are the changes in this PR? Thanks. |
@jjgao is it changed from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kalletlak I think I may have miscommunicated. We should revert to the previous sentence. "... in other tabs" should only be used in the Overlap
tab.
The real issue is that the same message is displayed even when a user chooses to including overlapping samples and patients.
In that case, we should just remove that sentence about "completely overlapping..." from all tabs.
E.g. in this session, the first warning should be removed from all tabs.
78715c2
to
ce0ea00
Compare
Fix part-2 of cBioPortal/cbioportal#8484
Fix cBioPortal/cbioportal#8476
Updated message