Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group comparison: update group exclusion message #3709

Merged
merged 1 commit into from
May 6, 2021

Conversation

kalletlak
Copy link
Member

@kalletlak kalletlak commented Apr 14, 2021

Fix part-2 of cBioPortal/cbioportal#8484
Fix cBioPortal/cbioportal#8476

Updated message

Screen Shot 2021-04-14 at 10 27 45 AM

Screen Shot 2021-04-14 at 10 27 28 AM

Copy link
Contributor

@adamabeshouse adamabeshouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean!

@jjgao
Copy link
Member

jjgao commented Apr 16, 2021

@kalletlak could you elaborate what are the changes in this PR? Thanks.

@kalletlak
Copy link
Member Author

@jjgao is it changed from
Screen Shot 2021-04-16 at 1 19 11 PM
to
Screen Shot 2021-04-16 at 1 19 19 PM

Copy link
Member

@jjgao jjgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalletlak I think I may have miscommunicated. We should revert to the previous sentence. "... in other tabs" should only be used in the Overlap tab.

The real issue is that the same message is displayed even when a user chooses to including overlapping samples and patients.

image

In that case, we should just remove that sentence about "completely overlapping..." from all tabs.

E.g. in this session, the first warning should be removed from all tabs.

image

@kalletlak kalletlak force-pushed the fix-8484-2 branch 4 times, most recently from 78715c2 to ce0ea00 Compare May 3, 2021 12:56
@alisman alisman merged commit a356b03 into cBioPortal:master May 6, 2021
@kalletlak kalletlak deleted the fix-8484-2 branch July 8, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

comparison/genomic alterations messaging is confused when one group is a subset of another
5 participants