Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VAF in genomic evolution tooltip #3748

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

adamabeshouse
Copy link
Contributor

@adamabeshouse adamabeshouse requested a review from inodb May 17, 2021 22:27
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Confirmed that this fixes the bug
Screen Shot 2021-05-17 at 8 02 02 PM

Note that it would be nice to show the actual read counts as well (can be in follow up PR)

Since the read coverage can vary a lot between positions and samples, it is useful to see the numerator/denominator

@inodb
Copy link
Member

inodb commented May 18, 2021

failing tests unrelated

@inodb inodb merged commit a01eae5 into cBioPortal:master May 18, 2021
@inodb inodb added the bug label May 18, 2021
@adamabeshouse adamabeshouse deleted the 8453-vaf branch May 18, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Something incorrect about VAF calculation on genomic alteration chart
2 participants