react-mutation-mapper updates #4304
Conversation
zhx828
commented
Jun 16, 2022
•
zhx828
commented
- Do not use Unknown as default cancer type
- The unknown will be interpreted as cancer type in OncoKB which will return inaccurate annotation
- When cancer type is not available, OncoKB will return all treatments for the mutation
- Show level associated cancer type instead of query cancer type in the OncoKBSummaryTable
- Create OncoKB LevelIcon and OncogenicIcon to reuse
| props.type === OncoKbCardDataType.BIOLOGICAL ? ( | ||
| <OncogenicIcon | ||
| oncogenicity={props.indicator?.oncogenic || ''} | ||
| showDescription |
There was a problem hiding this comment.
I know it is minor but a prop without a value always bothers me
| showDescription | |
| showDescription={true} |
There was a problem hiding this comment.
Is this the convention in portal? We don't specify true in oncokb anymore
There was a problem hiding this comment.
I don't think we have a strict rule about this, but I think the majority of the boolean props in portal codebase have the explicit ={true}.
|
@alisman could you review when you get a chance? The failing e2e tests are irrelevant to the pr. |
| props.indicator | ||
| )} | ||
| /> | ||
| props.type === OncoKbCardDataType.BIOLOGICAL ? ( |
There was a problem hiding this comment.
in general lets avoid nested ternary. just too difficult to read
|
@zhx828 i want to wait till after 5.0.0 release to merge this. can't take any more conflicts and we need to meet tuesday deadline. |
|
Rebase, pass tests and let's merge this? @alisman @onursumer |
Let me rebase. |
- The unknown will be interpreted as cancer type in OncoKB which will return inaccurate annotation - When cancer type is not available, we should display all treatments for the mutation
Signed-off-by: Hongxin <[email protected]>
inodb
added
the
cl-external-api
