Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize levelExcludedCancerTypes from OncoKB when showing cancer type name #4364

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

zhx828
Copy link
Member

@zhx828 zhx828 commented Sep 1, 2022

This is the change to work with the upcoming OncoKB release.

Copy link
Member

@onursumer onursumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just commented on a few minor things

packages/react-mutation-mapper/src/util/OncoKbUtils.ts Outdated Show resolved Hide resolved
packages/react-mutation-mapper/src/util/OncoKbUtils.ts Outdated Show resolved Hide resolved
Copy link
Member

@onursumer onursumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@zhx828
Copy link
Member Author

zhx828 commented Sep 6, 2022

Failing tests are irrelevant to this PR. I will send another PR to fix the oncokb test.

@zhx828 zhx828 merged commit c20f897 into cBioPortal:master Sep 6, 2022
@zhx828 zhx828 deleted the update-oncokb branch September 6, 2022 19:00
@dippindots dippindots added the cl-package Improvements related to a package label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cl-package Improvements related to a package oncokb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants