Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NP instead of NS for Mutations in Download tab #5057

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

arishta
Copy link
Contributor

@arishta arishta commented Nov 28, 2024

Fixes cBioPortal/cbioportal#10789. Use NP (Not profiled) across all types of alterations (mutations was using NS (Not Sequenced) instead of NP)

  • Change mutation data download format to display 'NP' instead of 'NS' for non-sequenced samples
  • Update generateMutationDownloadData function in DownloadUtils.ts to use 'NP' as the default value for non-sequenced samples

Here is a before and after screenshot of the file.

Screenshot 2024-11-28 at 11 13 43 AM

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 1da7f78
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/674a89b387171800083eca8d
😎 Deploy Preview https://deploy-preview-5057.cancerrevue.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@arishta
Copy link
Contributor Author

arishta commented Nov 28, 2024

Hi @inodb
Please review this PR, it solves this issue: cBioPortal/cbioportal#10789

@arishta arishta changed the title Modified EFGR values for Mutations in Download tab #10789 Modified EFGR values for Mutations in Download tab Nov 29, 2024
@arishta arishta force-pushed the update-mutations-tab-ESGR-column branch from e17d70c to 1da7f78 Compare November 30, 2024 03:42
@inodb inodb changed the title #10789 Modified EFGR values for Mutations in Download tab Use NP instead of NS for Mutations in Download tab Dec 16, 2024
@inodb inodb added the bug label Dec 16, 2024
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @arishta-dev !

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @arishta-dev !

@inodb inodb merged commit caf4789 into cBioPortal:master Dec 16, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use NP consistently in download tab
2 participants