Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clinical data counts (use new view that materializes null clinical data entrees) #10833

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

alisman
Copy link
Contributor

@alisman alisman commented Jun 14, 2024

Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • a
  • b

Checks

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

@alisman alisman changed the base branch from master to demo-rfc80-poc June 14, 2024 21:13
@alisman alisman requested a review from haynescd June 19, 2024 22:16
@@ -0,0 +1,46 @@
-- clinical_data_derived
DROP TABLE IF EXISTS clinical_data_derived
CREATE TABLE IF NOT EXISTS clinical_data_derived
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to have this convention. Where we define the tables and the insert statements in one file? or the split file approach?

haynescd
haynescd previously approved these changes Jun 20, 2024
@alisman alisman merged commit 464f442 into cBioPortal:demo-rfc80-poc Jun 20, 2024
7 of 12 checks passed
@alisman alisman deleted the fixClinical branch June 20, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants