Do not use clinical data MVs #10847
Merged
Do not use clinical data MVs #10847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onursumer
force-pushed
the
do-not-use-clinical-data-mvs
branch
from
3abfbe9 to
2e14852
Compare
onursumer
force-pushed
the
do-not-use-clinical-data-mvs
branch
2 times, most recently
from
542286f to
1b168a1
Compare
haynescd
reviewed
Jun 24, 2024
src/main/resources/org/cbioportal/persistence/mybatisclickhouse/StudyViewFilterMapper.xml
Show resolved
Hide resolved
haynescd
reviewed
Jun 24, 2024
src/main/resources/org/cbioportal/persistence/mybatisclickhouse/StudyViewMapper.xml
Outdated
Show resolved
Hide resolved
haynescd
reviewed
Jun 24, 2024
src/main/resources/org/cbioportal/persistence/mybatisclickhouse/StudyViewMapper.xml
Show resolved
Hide resolved
haynescd
reviewed
Jun 24, 2024
src/main/java/org/cbioportal/service/impl/StudyViewColumnarServiceImpl.java
Outdated
Show resolved
Hide resolved
…c_mv and patient_clinical_attribute_numeric_mv
…ric_mv and patient_clinical_attribute_numeric_mv
haynescd
force-pushed
the
do-not-use-clinical-data-mvs
branch
from
7095007 to
8fd08c2
Compare
haynescd
previously approved these changes
Jun 24, 2024
…clinical-data-mvs
haynescd
added a commit
that referenced
this pull request
Nov 25, 2024
* use clinical_data_derived instead of sample_clinical_attribute_numeric_mv and patient_clinical_attribute_numeric_mv * use clinical_attribute_meta instead of sample_clinical_attribute_numeric_mv and patient_clinical_attribute_numeric_mv * remove unused clinical data count methods and SQL * fix numericalClinicalDataCountFilter * Move CategoricalClinicalAttributeFilter to repository * remove unused columns * Add override to methods --------- Co-authored-by: haynescd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clinical_data_derivedtable when filtering both numerical and categorical clinical dataclinical_attribute_metatable to group clinical attribute names