Add tests for case list sample counts endpoint #10935
Conversation
src/test/java/org/cbioportal/persistence/mybatisclickhouse/CaseListSamplesCountsTest.java
Outdated
Show resolved
Hide resolved
alisman
force-pushed
the
unit-sample-list
branch
from
35206fc to
eb86894
Compare
| @@ -107,11 +109,35 @@ public Map<String, ClinicalDataType> getClinicalAttributeDatatypeMap() { | |||
|
|
|||
| return attributeDatatypeMap; | |||
| } | |||
|
|
|||
| public static List<CaseListDataCount> mergeCaseListCounts(List<CaseListDataCount> counts) { | |||
There was a problem hiding this comment.
@haynescd i'm assuming that this should go in some util? let me know the right place or if this is ok to just have it hanging out here.
FYI, i don't love that this merging is done at repository level because it suggest that the result of the underlying mapper is legitimate. it's not. the result must be merged. but i can't figure out a way to do that operation in SQL. ideally, it would be done in the mapper, but the mapper methods have no java implementation so ... what to do?
There was a problem hiding this comment.
So, I would suggest doing this at the service layer.
Creating a class CaseListService? Or whatever where this logic lived.
And the Repository would return getCaseListDataCountsPerStudy()
That way the mapper is still correct and you can do the business logic of merging in the service layer
|
Small unused import but everything else looks good |
alisman
force-pushed
the
unit-sample-list
branch
from
7e1819a to
a74cade
Compare
|
* Add tests for case list sample counts endpoint and fix merge of lists across studies
No description provided.