spark backend for sample-counts api #6475
Conversation
...nce/persistence-spark/src/main/java/org/cbioportal/persistence/spark/util/ParquetWriter.java
Outdated
Show resolved
Hide resolved
| @@ -36,12 +37,18 @@ | |||
| @Qualifier("sampleSparkRepository") | |||
| private SampleRepository sampleSparkRepository; | |||
| @Autowired | |||
| private CopyNumberSegmentSparkRepository copyNumberSegmentSparkRepository; | |||
There was a problem hiding this comment.
Is this not implementing the CopyNumberSegmentRepos?
There was a problem hiding this comment.
This is another case where the method returns internalIds and filters based on that. (List<Integer> samplesWithCopyNumberSeg = copyNumberSegmentRepository.fetchSamplesWithCopyNumberSegments()) So the workaround was to create a method that returns List<String> sampleIds and create another method in SampleSeriviceImpl.
There was a problem hiding this comment.
Why not introduce a method to the interface which returns a List (or return List and have the service process internal ids or stable sample ids as required)?
There was a problem hiding this comment.
thanks for the suggestion. I added a method in the interface that returns a list of Samples.
service/src/main/java/org/cbioportal/service/impl/SampleServiceImpl.java
Outdated
Show resolved
Hide resolved
spark backend for api/sample-counts/fetch.
Reviewers:
@kalletlak @n1zea144