Pick the proper fusion gene partner #8602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhx828
force-pushed
the
fix-fusion-gene-issue
branch
from
9bc5c5e to
2132cee
Compare
zhx828
force-pushed
the
fix-fusion-gene-issue
branch
from
2132cee to
8298c22
Compare
kalletlak
reviewed
May 17, 2021
| if (site1Gene != null && !site1Gene.getEntrezGeneId().equals(fusion.getEntrezGeneId())) { | ||
| pickedGene = site1Gene; | ||
| } | ||
| if (site2Gene != null && !site2Gene.getEntrezGeneId().equals(fusion.getEntrezGeneId())) { |
There was a problem hiding this comment.
shouldn't this be in else block or pickedGene == null needs to be included in if caluse
zhx828
force-pushed
the
fix-fusion-gene-issue
branch
from
8298c22 to
5a84cd6
Compare
kalletlak
approved these changes
May 17, 2021
| if (site2Gene != null) { | ||
| structuralVariant.setSite2EntrezGeneId(site2Gene.getEntrezGeneId()); | ||
| structuralVariant.setSite2HugoSymbol(site2Gene.getHugoGeneSymbol()); | ||
| // we need to pick the right gene since the fusion gene has been assigned to structural variant site1 |
There was a problem hiding this comment.
site2Gene is used if the first condition fails. may be move this inside else block
zhx828
force-pushed
the
fix-fusion-gene-issue
branch
from
5a84cd6 to
fa8f0c9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #8571