For sample pre/post treatment use Sample acq or Specimen track #9984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- People want samples to be added to the treatments table only if they have a sample aquisition date - You should figure out if this should be configurable or not. As is, you're probably removing the sample treatment chart from many public studies
dippindots
force-pushed
the
demo-genie-treatments-fix
branch
from
00fc349 to
86e7402
Compare
dippindots
force-pushed
the
demo-genie-treatments-fix
branch
from
86e7402 to
ccf129e
Compare
inodb
changed the title
inodb
reviewed
Jan 30, 2023
| @@ -33,6 +33,7 @@ | |||
| INNER JOIN cancer_study ON patient.CANCER_STUDY_ID = cancer_study.CANCER_STUDY_ID | |||
| <include refid="where"/> | |||
| AND clinical_event_data.KEY = 'SAMPLE_ID' | |||
| AND (clinical_event.EVENT_TYPE = 'Sample Acquisition' OR clinical_event.EVENT_TYPE = 'SPECIMEN') | |||
There was a problem hiding this comment.
@dippindots maybe good to allow case insensitive here as well as underscores, like: https://github.com/cBioPortal/cbioportal-frontend/pull/4489/files#diff-61b054d9b46310665b83bb6e1754f86f4d019ceadecd86979d51d608080d007aR98-R99
|
Kudos, SonarCloud Quality Gate passed!
|
dippindots
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9966
Describe changes proposed in this pull request:
clinical_event.EVENT_TYPEisSample AcquisitionorSPECIMEN, case insensitive)