Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make scaling none skip #53

Merged
merged 2 commits into from
Sep 16, 2024
Merged

refactor: make scaling none skip #53

merged 2 commits into from
Sep 16, 2024

Conversation

jonathan-mayer
Copy link
Member

Motivation

Currently whenever a workloads layers don't have any scaling parameters specified, the downscaler throws an error. This should just be a debug text.

Changes

Tests done

TODO

@jonathan-mayer jonathan-mayer added the bug Something isn't working label Sep 16, 2024
@jonathan-mayer jonathan-mayer self-assigned this Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Warning: Merging this PR will result in a new release because the appVersion in Chart.yaml has changed to 1.0.1. Please confirm this by adding the new release label before merging.

@github-actions github-actions bot added the needs approval This pull request needs additional approval label Sep 16, 2024
@jonathan-mayer jonathan-mayer added new release This is a new release of the GoKubeDownscaler and removed needs approval This pull request needs additional approval new release This is a new release of the GoKubeDownscaler labels Sep 16, 2024
JTaeuber
JTaeuber approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@JTaeuber JTaeuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JTaeuber JTaeuber merged commit d159ef4 into main Sep 16, 2024
7 of 8 checks passed
@JTaeuber JTaeuber deleted the refactor/make-scaling-none-skip branch September 16, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JTaeuber JTaeuber JTaeuber approved these changes

@jon4skl jon4skl Awaiting requested review from jon4skl jon4skl is a code owner

Assignees

@jonathan-mayer jonathan-mayer

Labels
bug Something isn't working new release This is a new release of the GoKubeDownscaler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathan-mayer @JTaeuber