Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/migrate pods workloads dashboards #26

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

puffitos
Copy link
Member

@puffitos puffitos commented Jan 9, 2025

Motivation

Final part of #17.

Changes done

  • Simplified namespace querying for almost all of the dashboards and fixed the broken queries for the namespace, pod variables.
  • Clicked in the UI and migrated the dashboards.

Tests done

Deployed in a CaaS development cluster.

Before

Pasted image 20250108185106

Pasted image 20250108185559

The workloads dashboard is completely broken:
Pasted image 20250108190246

The (pods) version as well
Pasted image 20250108190331

After

Pasted image 20250108185154

Pasted image 20250108185500

Pasted image 20250108190039

Pasted image 20250108190702

Dashboard use non-deprecated grafana components and now work properly

Signed-off-by: Bruno Bressi <[email protected]>
Something went wrong during the last copy paste operation probably

Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
@puffitos puffitos added bug Something isn't working area/dashboards Issues and PRs regarding the grafana dashboards shipped with the chart. labels Jan 9, 2025
@puffitos puffitos added this to the 1.0.0 milestone Jan 9, 2025
@puffitos puffitos requested review from y-eight and CerRegulus January 9, 2025 09:10
@puffitos puffitos self-assigned this Jan 9, 2025
Copy link
Contributor

@CerRegulus CerRegulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@puffitos puffitos merged commit a38ca3c into main Jan 10, 2025
1 check passed
@puffitos puffitos deleted the chore/migrate-pods-workloads-dashboards branch January 10, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboards Issues and PRs regarding the grafana dashboards shipped with the chart. bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants