-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to kube stack 58.4.0 & prepare for deprecation of cattle.monitoring.io #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the heavily outdated docs and simplified the structure of the documentation.
added makefile to bundle chart
Updated chart to use the same version as the latest caas-cluster-monitoring chart
Removed comments, old values, wrong values. The new values won't deploy a fully working project-monitoring (the old ones didn't either), but now it's hopefully clearer what each value does. An installation via the UI should possibly even work now, since the CRDs were removed from the chart completely.
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Since only caas-project-owners have the verb view on prometheus.monitoring.coreos.com they can also pass it down to their serviceaccounts, which will need to parse the central prometheus database for federated metrics for their own namespaces. Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Prometheus Auth will only use the `prometheus.monitoring.coreos.com` Resource to do its validation so the users of this helm chart need only that. Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
y-eight
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The sidecar needs more juice for the default configuration Signed-off-by: Bruno Bressi <[email protected]>
JTaeuber
approved these changes
Oct 22, 2024
eumel8
reviewed
Oct 22, 2024
eumel8
reviewed
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To update the prometheus stack components, which were severely outdated and prepare the monitoring chart up to speed with the deprecation of the monitoring.cattle.io API group, which won't be used in the future (see caas-team/prometheus-auth#19)
Changes
TODO
Features
A new, final
target_matchers
in theinhibit_rules
for AlertmanagerConfig, to inhibit more Alerts:Deprecation Warning
** This project monitoring version won't work with older versions of caas-cluster-monitoring (< 0.0.13).**
The ServiceAccount isn't allowed to
view
prometheus.monitoring.cattle.io
, but onlyprometheus.monitoring.coreos.com
. This is part of a bigger deprecation we're doing to remove this non-existent API Group from our monitoring stack.Smaller changes
Other changes, not important for release notes
#magic___^_^___line
added to alertmanager config (autoformatting, nothing to worry about, was the same in caas-cluster-monitoring) -> we should move the template to a file.(this may break the rule, nothing we can do here)The following prom rules were also changed:
Tests done
A previous version (which was exactly similar to this one) is already running in our dev clusters. Still open: