New Feature - Downscaling PodDisruptionBudgets #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-esp
requested review from
Fovty,
jonathan-mayer and
JTaeuber
as code owners
Fovty
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This Pull Request will align the PodDisruptionBudgets values with the replicas present inside the Deployments / StatefulSets at downtime. This feature is useful when PDB are massively used inside the Cluster, It will help the Cluster Autoscaler or Karpenter to better organize node scaling and consolidation
Note: this PR was originally made on Codeberg by sheogorath, however I added a couple of tests inside scaler.py in order to increase the coverage
Changes
Tests done
tests inside test_scaler.py and test_autoscale_resource.py
TODO