Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced Tests For Scaled Objects Downscaling/Upscaling #92

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Enhanced Tests For Scaled Objects Downscaling/Upscaling #92

merged 3 commits into from
Aug 26, 2024

Conversation

samuel-esp
Copy link
Collaborator

Motivation

  1. Enhanced Tests For Scaled Objects Downscaling/Upscaling.
  2. Added inside keda.py a logic to handle "autoscaling.keda.sh/paused-replicas" is None

The second behavior described above only happens inside test classes, this is for a reason:

  • In real life Kubernetes will delete the annotation when it is set to None
  • In Python it will be assigned the real None type

Changes

Enhanced Tests For Scaled Objects Downscaling/Upscaling

Tests done

Unit Tests

TODO

  • I've assigned myself to this PR

@samuel-esp samuel-esp mentioned this pull request Aug 23, 2024
Merged
1 task
jonathan-mayer
jonathan-mayer approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@jonathan-mayer jonathan-mayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuel-esp samuel-esp merged commit 6cd190f into caas-team:main Aug 26, 2024
1 check passed
@samuel-esp samuel-esp mentioned this pull request Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-mayer jonathan-mayer jonathan-mayer approved these changes

@runningman84 runningman84 runningman84 approved these changes

@Fovty Fovty Awaiting requested review from Fovty Fovty is a code owner

@JTaeuber JTaeuber Awaiting requested review from JTaeuber JTaeuber is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuel-esp @runningman84 @jonathan-mayer