Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 308 #312

Merged
merged 6 commits into from
Jun 25, 2019
Merged

Issue 308 #312

merged 6 commits into from
Jun 25, 2019

Conversation

rhythnic
Copy link
Contributor

@rhythnic rhythnic commented Jun 24, 2019

What does this PR do?

  • Support bulk import of devices; /api/applications/:id/import-devices
  • Increment minor version for release candidates
  • Update API for device.create and deviceNetworkTypeLink.create to accept data object instead of list of arguments.
  • Add E2E test for bulk device import

Do you have any concerns with this PR?

The endpoint doesn't support file uploads. It's just JSON. I plan to parse the CSV file in the web client.

How can the reviewer verify this PR?

Test new endpoint

Any background context you want to provide?

The bulk import endpoint is designed to eventually support LoRa devices, but it doesn't yet.

Screenshots or logs (if appropriate)

Questions:

@rhythnic rhythnic merged commit c73a7ae into master Jun 25, 2019
@rhythnic rhythnic deleted the issue-308 branch June 25, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant