Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter for Memcached #22

Closed
cabol opened this issue Jul 16, 2018 · 7 comments
Closed

Adapter for Memcached #22

cabol opened this issue Jul 16, 2018 · 7 comments
Labels

Comments

@cabol
Copy link
Owner

cabol commented Jul 16, 2018

No description provided.

@cabol cabol added the feature label Jul 16, 2018
@cabol cabol changed the title Implement adapter for Memcached Adapter for Memcached Jul 16, 2018
@vasuadari
Copy link

I would like to work on this. Has someone picked this up already?

@cabol
Copy link
Owner Author

cabol commented Feb 8, 2019

@vasuadari not yet, I'm glad you want to work on it :), so feel free to do it. I've made a bit of progress nebulex_memcached_adapter, but I haven't been able to continue. So again, feel free to start your own repo or work on the existing one (it's your call!). Any doubt please let me know. Thanks and I stay tuned!

@vasuadari
Copy link

not yet, I'm glad you want to work on it :), so feel free to do it.

Thanks

Any doubt please let me know.

Sure 👍

@vasuadari
Copy link

vasuadari commented Mar 3, 2019

@cabol I have created a new repo nebulex_memcached_adapter. Except for Nebulex.Cache.Queryable APIs, every other functions are supported however there is one catch with get_many implementation for memcached. Even though memcached provides multi_get call unlike redis it doesn't return nil for missing keys which is a problem. As a workaround i am currently doing multiple get :(.

Please check the repo and let me know about your views.

@cabol
Copy link
Owner Author

cabol commented Mar 4, 2019

@vasuadari looks very good so far, nice work 👍

I'll update Nebulex pointing to the new Memcached adapter 😀

Once you have a stable release, we have to provide the distributed part on top of that, so let me know when it is ready!

BTW, try to add CI with test, coverage, check style, etc.

Again, thanks a lot for your contribution and let me know if you need something from my side!!

@vasuadari
Copy link

@cabol

I'll update Nebulex pointing to the new Memcached adapter

Thanks :)

Once you have a stable release, we have to provide the distributed part on top of that, so let me know when it is ready!

Sure, i'll spend some time on that.

BTW, try to add CI with test, coverage, check style, etc.

Definitely i was planning to set it up but couldn't find time. Will set it up soon.

Again, thanks a lot for your contribution and let me know if you need something from my side!!

Sure 👍

@cabol
Copy link
Owner Author

cabol commented Apr 24, 2019

Since there is significant work already done for this adapter and a different repo nebulex_memcached_adapter, any issue, improvement, suggestion, etc., regarding to Memcached adapter should be reported in there.

Thank you so much @vasuadari for your contribution :) !!

@cabol cabol closed this as completed Apr 24, 2019
PragTob added a commit to PragTob/nebulex that referenced this issue Jun 24, 2024
Mentioning memcached in the README seems odd as:

* it's not one of the listed adapters
* cabol#22 mentions it and there is an adapter but it seems not actively maintained (last commit 5 years ago): https://github.com/vasuadari/nebulex_memcached_adapter

So I think it's no longer the case and can hence be removed not to confuse people like me :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants