Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build cactus file converter #2

Merged
merged 7 commits into from
Jan 10, 2023
Merged

Conversation

Philip-robinson
Copy link

@Philip-robinson Philip-robinson commented Jan 10, 2023

The original issue with columns H and I hidden and the cell cpntaining "Ground Up" and "Primary" both being 3 cells wide and each incorporating one of the hidden columns.

When converted to HTML became

Which has:

  • The "Ground Up" column 3 cells wide - it should be 2.
  • The "Primary" column not visible.

It now becomes

Which is correct for both "Ground Up" and "Primary", both visible and both 2 cells wide.

The modifications needed to fix the merged cell-hidden columns conflict are all in the file sc/source/filter/html/htmlexp.cxx.

This fixes the issues related to generating HTML from spreadsheets that were notified notified these are:

If cells from multiple columns are merged and the first column of this set is hidden the whole merged cell disappears.
If cells from multiple columns are merged and a column other than the first is hidden the merged cell is displayed with the wrong colspan.

In addition:

If cells from multiple rows are merged and one of the rows is hidden other than the first , the merged cell was displayed with the wrong rowspan.

These have all been fixed, however there is still a related defect:

If cells from multiple rows are merged and the first row is hidden, the merged cell is not displayed.

This has not been fixed as it was deemed that it would take longer that is reasonable for what is expected to be a vanishingly rare event, this is left as technical debt.

Verified

This commit was signed with the committer’s verified signature.
frostming Frost Ming
…cept

special case of a hidden row which is also the first row of a group of
vertically merged cells.

Change-Id: I4312b4ecde72f5d164e46f535602c7ae584f90f0

Verified

This commit was signed with the committer’s verified signature.
frostming Frost Ming

Verified

This commit was signed with the committer’s verified signature.
frostming Frost Ming
Change-Id: I10678ee1dcade8d2050994b8bc2bd691a6b305a3
Change-Id: I95221e023c12403012669977d737e5cd4f8c3fa7
@Philip-robinson Philip-robinson merged commit 42d15f4 into master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant