Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverseproxy: default to port 80 for port-less upstream dial addresses #3772

Merged
merged 2 commits into from
Oct 1, 2020
Merged

reverseproxy: default to port 80 for port-less upstream dial addresses #3772

merged 2 commits into from
Oct 1, 2020

Conversation

mohammed90
Copy link
Member

@mohammed90 mohammed90 commented Oct 1, 2020 •
edited
Loading

Fixes #3761

@mohammed90 mohammed90 force-pushed the default-upstream-port branch from 40ca4a4 to 1291068 Compare October 1, 2020 19:04
@francislavoie francislavoie added the bug 🐞 Something isn't working label Oct 1, 2020
@francislavoie francislavoie added this to the v2.2.1 milestone Oct 1, 2020
mholt
mholt approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much! This is great, and appreciate the test case.

@mholt mholt merged commit aa9c3eb into master Oct 1, 2020
@mholt mholt deleted the default-upstream-port branch October 1, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
v2.2.1
Development

Successfully merging this pull request may close these issues.

provision http.handlers.reverse_proxy: invalid start port: strconv.ParseUint: parsing "": invalid syntax
3 participants
@mohammed90 @mholt @francislavoie