Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverse_proxy: Fix random_choose lb_policy #3811

Merged
merged 1 commit into from
Nov 16, 2020
Merged

reverse_proxy: Fix random_choose lb_policy #3811

merged 1 commit into from
Nov 16, 2020

Conversation

d-masson
Copy link
Contributor

@d-masson d-masson commented Oct 19, 2020 •
edited
Loading

fix #3810

@d-masson d-masson mentioned this pull request Oct 19, 2020
Closed
@d-masson d-masson force-pushed the fix_RandomChoiceSelection branch from 000c9fe to 24ae784 Compare October 19, 2020 11:13
mholt
mholt requested changes Oct 19, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report and the quick fix! I have a few questions/nits before we merge this.

modules/caddyhttp/reverseproxy/selectionpolicies.go Outdated Show resolved Hide resolved
modules/caddyhttp/reverseproxy/selectionpolicies.go Outdated Show resolved Hide resolved
@mholt mholt added the under review 🧐 Review is pending before merging label Oct 19, 2020
@mholt mholt added this to the v2.3.0 milestone Oct 19, 2020
@d-masson d-masson force-pushed the fix_RandomChoiceSelection branch 2 times, most recently from 7a4eef9 to 6babe8d Compare October 20, 2020 13:27
@d-masson d-masson force-pushed the fix_RandomChoiceSelection branch from 6babe8d to fd5285f Compare October 20, 2020 13:30
@d-masson d-masson requested a review from mholt October 20, 2020 15:35
mholt
mholt approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this looks good. Thanks so much for your contribution! Appreciate the fix!

@mholt mholt removed the under review 🧐 Review is pending before merging label Nov 16, 2020
@mholt mholt merged commit 99b8f44 into caddyserver:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.

lb_policy random_choose may failed when some upsteam are down
2 participants
@d-masson @mholt