Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverseproxy: Caddyfile health check headers, host header support #3948

Merged
merged 4 commits into from
Jan 4, 2021
Merged

reverseproxy: Caddyfile health check headers, host header support #3948

merged 4 commits into from
Jan 4, 2021

Conversation

bookiu
Copy link
Contributor

@bookiu bookiu commented Dec 31, 2020

reverse_proxy:
health check headers can be set through Caddyfile using health_headers directive
health check header host can be set properly

@bookiu
reverse_proxy: 1.health check headers can be set through Caddyfile us…
96d1391 
…ing health_headers directive; 2.health check header host can be set properly
@CLAassistant
Copy link

CLAassistant commented Dec 31, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

francislavoie
francislavoie requested changes Dec 31, 2020
View reviewed changes
modules/caddyhttp/reverseproxy/caddyfile.go Outdated Show resolved Hide resolved
modules/caddyhttp/reverseproxy/caddyfile.go Outdated Show resolved Hide resolved
modules/caddyhttp/reverseproxy/healthchecks.go Show resolved Hide resolved
@francislavoie
Copy link
Member

francislavoie commented Dec 31, 2020 •
edited
Loading

Please also add a Caddyfile adapt test, see https://github.com/caddyserver/caddy/tree/master/caddytest/integration/caddyfile_adapt

And don't forget to sign the CLA!

@francislavoie francislavoie added this to the v2.4.0 milestone Dec 31, 2020
@francislavoie francislavoie changed the title health check headers can be set through Caddyfile and host header can be used reverseproxy: Caddyfile health check headers, host header support Dec 31, 2020
@francislavoie francislavoie added the under review 🧐 Review is pending before merging label Dec 31, 2020
@bookiu
reverse_proxy:
2526997 
replace example with syntax definition
inline health_headers directive parse function
mholt
mholt requested changes Dec 31, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great PR!

Will look forward to merging this shortly after the 2.3 release (today or tomorrow).

Looks good, just wanted to double check a couple things.

modules/caddyhttp/reverseproxy/caddyfile.go Show resolved Hide resolved
modules/caddyhttp/reverseproxy/caddyfile.go Outdated Show resolved Hide resolved
mholt
mholt approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@mholt mholt requested a review from francislavoie January 4, 2021 18:13
@mholt mholt merged commit 3c9256a into caddyserver:master Jan 4, 2021
@mholt mholt removed the under review 🧐 Review is pending before merging label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francislavoie francislavoie francislavoie approved these changes

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bookiu @CLAassistant @francislavoie @mholt