caddyfile: reject cyclic imports #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammed90
changed the title
|
Converting it to draft as @francislavoie and I found more corner cases |
mohammed90
force-pushed
the
recursive-import
branch
from
1bc9185 to
db4c904
Compare
|
I opted for minimal implementation of the graph to avoid pulling an additional dep just for tracking cycles. |
mholt
requested changes
Apr 8, 2021
mholt
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
Cool, hopefully this will help a few people and prevent some problems! Thanks for contributing this @mohammed90 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an edge case of Caddyfile import itself. I don't imagine anyone deliberately self-importing a Caddyfile but could happen if glob expansion wasn't vetted by the user.