Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Build and test on Go 1.16, bump minimum to 1.15 #4024

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

francislavoie
Copy link
Member

🎉

@francislavoie francislavoie added the CI/CD 🔩 Automated tests, releases label Feb 17, 2021
@francislavoie francislavoie added this to the v2.4.0 milestone Feb 17, 2021
.goreleaser.yml Outdated Show resolved Hide resolved
Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Go version in go.mod needs to be bumped up to 1.15. The commit ab80ff4 (admin: remote management) uses the PublicKey#Equal method, which was added in go1.15.

caddy/admin.go

Lines 552 to 553 in ec3ac84

comparer, ok := peerCert.PublicKey.(interface{ Equal(crypto.PublicKey) bool })
if !ok || !comparer.Equal(allowedKey) {

Which means we need to drop '1.14' in the CI flows as well.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/cross-build.yml Outdated Show resolved Hide resolved
@francislavoie francislavoie changed the title ci: Build and test on Go 1.16, enable darwin/arm for goreleaser ci: Build and test on Go 1.16, drop 1.14 Feb 18, 2021
@francislavoie francislavoie changed the title ci: Build and test on Go 1.16, drop 1.14 ci: Build and test on Go 1.16, bump minimum to 1.15 Feb 18, 2021
@francislavoie
Copy link
Member Author

Oops - @mholt you'll need to turn off the requirement in the repo settings that the test (macos-latest, 1.14) and such pass.

@mholt
Copy link
Member

mholt commented Feb 18, 2021

Thanks, good point. Done!

@francislavoie
Copy link
Member Author

francislavoie commented Feb 18, 2021

👍

I'm thinking this is good to go?

@francislavoie francislavoie merged commit 5376e51 into caddyserver:master Feb 18, 2021
@francislavoie francislavoie deleted the go-1.16 branch February 18, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD 🔩 Automated tests, releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants