-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Build and test on Go 1.16, bump minimum to 1.15 #4024
Conversation
1da84cc
to
9550317
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Go version in go.mod needs to be bumped up to 1.15. The commit ab80ff4 (admin: remote management) uses the PublicKey#Equal method, which was added in go1.15.
Lines 552 to 553 in ec3ac84
comparer, ok := peerCert.PublicKey.(interface{ Equal(crypto.PublicKey) bool }) | |
if !ok || !comparer.Equal(allowedKey) { |
Which means we need to drop '1.14'
in the CI flows as well.
Oops - @mholt you'll need to turn off the requirement in the repo settings that the |
Thanks, good point. Done! |
👍 I'm thinking this is good to go? |
🎉