Allow configuration of loggers through Caddyfile global options #4028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kujenga
force-pushed
the
at/caddy-log-safety-global-opt
branch
from
7040240 to
89eec90
Compare
kujenga
force-pushed
the
at/caddy-log-safety-global-opt
branch
from
89eec90 to
e66bcbb
Compare
kujenga
force-pushed
the
at/caddy-log-safety-global-opt
branch
from
e66bcbb to
5e01204
Compare
kujenga
changed the title
kujenga
force-pushed
the
at/caddy-log-safety-global-opt
branch
2 times, most recently
from
c8f5a6f to
db291e8
Compare
|
Hi @mholt @francislavoie , just checking in, any thoughts on the simplified approach this PR now takes? Happy to make any further iterations as wanted. |
francislavoie
approved these changes
Mar 8, 2021
francislavoie
requested changes
Mar 8, 2021
kujenga
force-pushed
the
at/caddy-log-safety-global-opt
branch
3 times, most recently
from
ebe14d9 to
5507ec4
Compare
|
Alright, this is rebased on master now as well, if there's anything else just let me know! |
kujenga
force-pushed
the
at/caddy-log-safety-global-opt
branch
from
5507ec4 to
7c2f314
Compare
francislavoie
previously approved these changes
Mar 11, 2021
This change is aimed at enhancing the logging module within the Caddyfile directive to allow users to configure logs other than the HTTP access log stream, which is the current capability of the Caddyfile [1]. The intent here is to leverage the same syntax as the server log directive at a global level, so that similar customizations can be added without needing to resort to a JSON-based configuration. Discussion for this approach happened in the referenced issue. Closes caddyserver#3958 [1] https://caddyserver.com/docs/caddyfile/directives/log
kujenga
force-pushed
the
at/caddy-log-safety-global-opt
branch
from
7c2f314 to
d99bbd7
Compare
|
Alright, this has been rebased on master and I believe the last comment is now addressed! |
francislavoie
approved these changes
Mar 12, 2021
|
Awesome, thank you! Feel free to ping me if anything does come up 👍 |
|
@kujenga would you like to take a shot at writing the docs for this? You can find them here https://github.com/caddyserver/website/blob/master/src/docs/markdown/caddyfile/options.md While you're at it, you could also add docs for the new redact filter to https://github.com/caddyserver/website/blob/master/src/docs/markdown/caddyfile/directives/log.md |
kujenga
added a commit
to kujenga/caddy-website
that referenced
this pull request
Mar 19, 2021
This corresponds with the changes in this PR: caddyserver/caddy#4028
kujenga
added a commit
to kujenga/caddy-website
that referenced
this pull request
Mar 27, 2021
This corresponds with the changes in this PR: caddyserver/caddy#4028
mholt
pushed a commit
to caddyserver/website
that referenced
this pull request
Apr 8, 2021
* caddyfile/directives/log: add docs for new replace directive This commit corresponds with the functionality added in this PR: caddyserver/caddy#4029 * caddyfile: add documentation for new global log option This corresponds with the changes in this PR: caddyserver/caddy#4028
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up on the previous attempt in #3968 but instead implemented as a global logging option.
It follows up on discussion in #3958 about adding more functionality to the Caddyfile. I also added in another commit for a small new "replace" filter aimed at the same goal as I wrote up in the original ticket, providing more tools to remove sensitive data from logs.
Closes #3958