fileserver: properly handle escaped/non-ascii paths #4332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows fails because the colon |
mohammed90
force-pushed
the
issue-4329
branch
from
56c9f9f to
88fe5eb
Compare
mholt
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
Thanks for the fix, I like the implementation, seems to do the right things at the right places, and the tests look good too.
If we're feeling good about this, feel free to merge it. 👍
I might add integration test for those non-ascii file names. Thoughts?
If you think it would be helpful, sure, but I think the unit tests are a great start.
francislavoie
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might add integration test for those non-ascii file names. Thoughts?
Closes #4329