fastcgi: Fix Caddyfile parsing when handle_response
is used
#4342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4322
Super simple, actually. The problem was that if
handle_response
contained aroot
directive, then it would actually get consumed ahead of time as a subdirective forphp_fastcgi
, breaking the tokens, triggering an error when parsing when passed down toreverse_proxy
.The fix is to only read
php_fastcgi
subdirectives if the nesting is1
, so we skip any that might appear within any sub-blocks.The test fails before the change, passes after.