Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxyprotocol: Add PROXY protocol support to reverse_proxy, add HTTP listener wrapper #5424

Merged
merged 7 commits into from
Mar 31, 2023
Merged

proxyprotocol: Add PROXY protocol support to reverse_proxy, add HTTP listener wrapper #5424

merged 7 commits into from
Mar 31, 2023

Conversation

gucki
Copy link
Contributor

@gucki gucki commented Mar 8, 2023

This is an updated (rebased to the current master and improved) version of #4855.

Please let me know if any changes are needed. Would be great to have this included in the next official release :-)

@CLAassistant
Copy link

CLAassistant commented Mar 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gucki gucki force-pushed the proxy-protocol-reverse-proxy-rebased branch from d436110 to 7573e08 Compare March 8, 2023 20:51
francislavoie
francislavoie reviewed Mar 8, 2023
View reviewed changes
@mholt
Copy link
Member

mholt commented Mar 9, 2023

Thank you for working on this! 🙌

@mholt mholt added this to the v2.7.0 milestone Mar 10, 2023
@WeidiDeng WeidiDeng mentioned this pull request Mar 15, 2023
Closed
@francislavoie francislavoie force-pushed the proxy-protocol-reverse-proxy-rebased branch from 29413ed to fc671d3 Compare March 22, 2023 07:41
@francislavoie francislavoie added the feature ⚙️ New feature or request label Mar 22, 2023
@francislavoie francislavoie changed the title Proxy protocol reverse proxy rebased proxyprotocol: Add PROXY protocol support to reverse_proxy, add HTTP listener wrapper Mar 22, 2023
@francislavoie francislavoie changed the title proxyprotocol: Add PROXY protocol support to reverse_proxy, add HTTP listener wrapper proxyprotocol: Add PROXY protocol support to reverse_proxy, add HTTP listener wrapper Mar 22, 2023
@francislavoie
Copy link
Member

Thanks for the work thus far @WeidiDeng @gucki, I'll finish this up once I'm done with the client_ip stuff, but this is looking good 👌

@francislavoie francislavoie force-pushed the proxy-protocol-reverse-proxy-rebased branch from 855ef74 to 8e411cd Compare March 27, 2023 22:49
@francislavoie francislavoie requested a review from mholt March 28, 2023 07:08
mholt
mholt approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you for the contribution! Let's give this a try.

@francislavoie francislavoie force-pushed the proxy-protocol-reverse-proxy-rebased branch from 8e411cd to d35cfc1 Compare March 31, 2023 21:24
@francislavoie francislavoie merged commit b6fe5d4 into caddyserver:master Mar 31, 2023
@mholt mholt mentioned this pull request May 15, 2023
Closed
@gucki gucki mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus left review comments

@francislavoie francislavoie francislavoie left review comments

@WeidiDeng WeidiDeng WeidiDeng left review comments

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
feature ⚙️ New feature or request
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
6 participants
@gucki @CLAassistant @mholt @francislavoie @mastercactapus @WeidiDeng