Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode: write status immediately when status code is informational #6164

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

WeidiDeng
Copy link
Member

@WeidiDeng WeidiDeng commented Mar 10, 2024

Context: https://caddy.community/t/disappear-103-early-hints-response-with-encode-enable-caddy-v2-7-6/23081

Write status immediately when status code is informational.

Also removed Hijack since if 101 is written beforehand, it's already written to the underlying response writer. If not, status should be written to the net.Conn. reverse_proxy write 101 to the response writer.

@francislavoie francislavoie added the bug 🐞 Something isn't working label Mar 10, 2024
@francislavoie francislavoie added this to the v2.8.0 milestone Mar 10, 2024
@francislavoie
Copy link
Member

Awesome 🎉

@dev-polymer
Copy link
Contributor

Hi, thanks for quick solution!
Awesomeness double-tested and confirmed 👍

Copy link
Collaborator

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francislavoie francislavoie merged commit e698ec5 into master Mar 10, 2024
25 checks passed
@francislavoie francislavoie deleted the fix-encode-103 branch March 10, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants