forwardauth: Skip copying missing response headers #6608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francislavoie
force-pushed
the
forward-auth-empty-headers
branch
from
6afa8a2 to
8bce42e
Compare
francislavoie
force-pushed
the
forward-auth-empty-headers
branch
from
8bce42e to
222a84f
Compare
mholt
approved these changes
Nov 4, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported here: https://caddy.community/t/copy-header-copying-empty-headers-with-authelia/25885, but I think it has been mentioned elsewhere before as well. Fixes #6610
Basically, because we use
ReplaceKnownin therequest_headerhandler for placeholders, thecopy_headershortcut forforward_authwould cause the request headers to be set to the placeholder string itself instead of skipping, when the response was missing that header.The fix is to use a
not varsmatcher to check that the response header placeholder has a non-empty value first.Unfortunately this produces some super verbose JSON config, but the behaviour will be more correct.