caddyhttp: Add {?query} placeholder
#6714
Merged
+30
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francislavoie
added
bug 🐞
francislavoie
changed the title
{prefixed_query} placeholder
whitestrake
reviewed
Nov 28, 2024
There was a problem hiding this comment.
Built and tested real quick - looks like this has handily fixed the repro I found in https://caddy.community/t/preserving-query-string-during-rewrite/26538/4
LGTM!
gingerbeardman
approved these changes
Nov 28, 2024
|
Thanks for fixing the bug I stumbled across! |
|
Hear me out for a sec, what if it was named |
|
Hmmmmmmmmmmmmmm... well nothing else we have currently has special chars in the placeholder. Maybe we do that only for the Caddyfile shortcut? |
francislavoie
changed the title
{prefixed_query} placeholder{?query} placeholder
|
Yeah, for the Caddyfile shortcut at least would be nice 👍 |
|
Yep already done @mholt 😅 |
francislavoie
force-pushed
the
prefixed-query
branch
from
3aced12 to
d5237a6
Compare
mholt
approved these changes
Dec 2, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a two in one:
{http.request.uri.prefixed_query}as the long-form and{?query}as the Caddyfile shorthand.php_fastcgicanonicalization redirect doesn't preserve the query 😬