Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run go mod tidy in the build environment #47

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Run go mod tidy in the build environment #47

merged 2 commits into from
Feb 5, 2021

Conversation

mohammed90
Copy link
Member

As of go 1.16, the go {build,test} commands don't modify the go.mod and go.sum files (see: https://golang.org/issue/40728). We, therefore, have to run go mod tidy to ensure the go.mod and go.sum files are consistent with the module requirements.

Closes #46

As of go 1.16, the `go {build,test}` commands don't modify the go.mod and go.sum files (see: https://golang.org/issue/40728). We, therefore, have to run `go mod tidy` to ensure the go.mod and go.sum files are consistent with the module requirements.

Closes #46
@mohammed90 mohammed90 requested a review from mholt February 5, 2021 17:24
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Mohammed! Beat me to it, as usual :)

@mholt mholt merged commit e7b19b1 into master Feb 5, 2021
@mohammed90 mohammed90 deleted the tidy-mod branch February 5, 2021 17:50
imiric pushed a commit to grafana/xk6 that referenced this pull request Mar 8, 2021
imiric pushed a commit to grafana/xk6 that referenced this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails under go1.16
2 participants