Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement workflow actions #790

Merged

Conversation

adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Jan 15, 2025

Summary

  • Extend the WorkflowAction type to depend on a result type (we'll need to do something similar for input too)
  • Add fields:
    • apiRoute: the route handler URL
    • getSuccessMessage: success message to show in snackbar after action succeeds
  • Add snackbar to Workflow Actions view to handle success notifications
  • Move modal content to separate file
  • Invoke actions using useMutation
  • Update configs with new values

Test plan

Added unit tests + ran locally.

Cancellation:
Screenshot 2025-01-15 at 1 22 31 PM

Failure to terminate:
Screenshot 2025-01-15 at 1 10 56 PM

@adhityamamallan adhityamamallan marked this pull request as ready for review January 15, 2025 15:38
@adhityamamallan adhityamamallan marked this pull request as draft January 15, 2025 16:02
@adhityamamallan
Copy link
Member Author

I'll put it back up for review once #791 is merged

@adhityamamallan adhityamamallan marked this pull request as ready for review January 16, 2025 12:11
@Assem-Uber Assem-Uber merged commit 944d9a6 into cadence-workflow:release/4.0.0 Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants