Fixes to date filter and datetime utils #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assem-Uber
reviewed
Jan 16, 2025
| @@ -40,9 +41,12 @@ export default function DomainWorkflowsArchivalHeader({ | |||
| !queryParams.timeRangeStartArchival && | |||
| !queryParams.timeRangeEndArchival | |||
| ) { | |||
| const now = dayjs(new Date()); | |||
There was a problem hiding this comment.
nit: dayjs() is now. No need to create a Date Object
Assem-Uber
approved these changes
Jan 16, 2025
adhityamamallan
merged commit 035cf68
into
cadence-workflow:release/4.0.0
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Updated unit tests + ran locally.
Screen.Recording.2025-01-16.at.4.24.04.PM.mov
Screen.Recording.2025-01-16.at.4.24.52.PM.mov