Fix public client default value after xdc switching to gRPC

[longquanzheng]

What changed?
Fix public client default value after xdc switching to gRPC

Why?
After this #4492 the default value of publicClient.hostPort is broken because GoSDK doesn't support gRPC yet.
errors about sys-worker startup:

{"level":"warn","ts":"2021-10-11T09:04:33.440-0700","caller":"internal/internal_worker.go:262","msg":"unable to verify if domain exist","Domain":"cadence-system","TaskList":"cadence-sys-processor-parent-close-policy","WorkerID":"42191@IT-USA-25920@cadence-sys-processor-parent-close-policy","WorkerType":"DecisionWorker","domain":"cadence-system","error":"code:unknown message:received unknown error calling service: \"cadence-frontend\", procedure: \"WorkflowService::DescribeDomain\", err: read tcp 127.0.0.1:54418->127.0.0.1:7833: read: connection reset by peer"}
{"level":"info","ts":"2021-10-11T09:04:33.440-0700","caller":"internal/internal_worker.go:834","msg":"Started Workflow Worker","Domain":"cadence-system","TaskList":"cadence-sys-processor-parent-close-policy","WorkerID":"42191@IT-USA-25920@cadence-sys-processor-parent-close-policy"}
{"level":"warn","ts":"2021-10-11T09:04:33.445-0700","caller":"internal/internal_worker.go:262","msg":"unable to verify if domain exist","Domain":"cadence-system","TaskList":"cadence-sys-processor-parent-close-policy","WorkerID":"42191@IT-USA-25920@cadence-sys-processor-parent-close-policy","WorkerType":"ActivityWorker","domain":"cadence-system","error":"code:unknown message:received unknown error calling service: \"cadence-frontend\", procedure: \"WorkflowService::DescribeDomain\", err: read tcp 127.0.0.1:54428->127.0.0.1:7833: read: connection reset by peer"}
{"level":"warn","ts":"2021-10-11T09:04:33.447-0700","caller":"internal/internal_worker.go:262","msg":"unable to verify if domain exist","Domain":"cadence-system","TaskList":"cadence-sys-processor-parent-close-policy","WorkerID":"42191@IT-USA-25920@cadence-sys-processor-parent-close-policy","WorkerType":"LocallyDispatchedActivityWorker","domain":"cadence-system","error":"code:unknown message:received unknown error calling service: \"cadence-frontend\", procedure: \"WorkflowService::DescribeDomain\", err: read tcp 127.0.0.1:54434->127.0.0.1:7833: read: connection reset by peer"}
{"level":"info","ts":"2021-10-11T09:04:33.447-0700","caller":"internal/internal_worker.go:859","msg":"Started Activity Worker","Domain":"cadence-system","TaskList":"cadence-sys-processor-parent-close-policy","WorkerID":"42191@IT-USA-25920@cadence-sys-processor-parent-close-policy"}
{"level":"info","ts":"2021-10-11T09:04:33.447-0700","msg":"First loading dynamic config","service":"cadence-worker","key":"system.enableFailoverManager,clusterName:cluster0","value":"true","default-value":"true","logging-call-at":"config.go:93"}
{"level":"info","ts":"2021-10-11T09:04:33.448-0700","caller":"internal/internal_worker.go:223","msg":"No logger configured for cadence worker. Created default one."}
{"level":"warn","ts":"2021-10-11T09:04:33.450-0700","caller":"internal/internal_worker.go:262","msg":"unable to verify if domain exist","Domain":"cadence-system","TaskList":"cadence-sys-failoverManager-tasklist","WorkerID":"42191@IT-USA-25920@cadence-sys-failoverManager-tasklist","WorkerType":"DecisionWorker","domain":"cadence-system","error":"code:unknown message:received unknown error calling service: \"cadence-frontend\", procedure: \"WorkflowService::DescribeDomain\", err: read tcp 127.0.0.1:54440->127.0.0.1:7833: read: connection reset by peer"}
{"level":"info","ts":"2021-10-11T09:04:33.450-0700","caller":"internal/internal_worker.go:834","msg":"Started Workflow Worker","Domain":"cadence-system","TaskList":"cadence-sys-failoverManager-tasklist","WorkerID":"42191@IT-USA-25920@cadence-sys-failoverManager-tasklist"}

The above errors are gone after this fix.

How did you test it?
Local test.

run make install-schema-xdc and then make cadence-server then ./cadence-server --zone xdc_cluster0 start

Potential risks

Release notes

Documentation Changes

[coveralls]

Pull Request Test Coverage Report for Build 28b8b206-2870-45c7-9866-c3ece15ed82e

• 11 of 13 (84.62%) changed or added relevant lines in 1 file are covered.
• 57 unchanged lines in 11 files lost coverage.
• Overall coverage increased (+0.05%) to 56.731%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
common/config/config.go	11	13	84.62%

Files with Coverage Reduction	New Missed Lines	%
service/history/execution/mutable_state_task_refresher.go	1	73.82%
service/matching/matcher.go	1	91.87%
common/membership/rpServiceResolver.go	2	73.58%
service/history/queue/timer_queue_processor.go	2	59.33%
service/matching/taskListManager.go	2	74.09%
common/cache/lru.go	3	90.73%
common/task/fifoTaskScheduler.go	3	84.54%
common/persistence/serialization/parser.go	4	65.41%
common/persistence/serialization/thrift_decoder.go	4	59.6%
common/persistence/sql/workflowStateMaps.go	11	85.5%

Totals
Change from base Build 28230baa-26b4-44c1-89bb-63d0de08c68e:	0.05%
Covered Lines:	81087
Relevant Lines:	142933

---

💛 - Coveralls

[vytautas-karpavicius]

Look good, thanks for the fix.

[vytautas-karpavicius]

Just FYI, Go has dedicated function for such address splitting/joining which has some additional logic: net.SplitHostPort and net.JoinHostPort

[longquanzheng]

yeah good point. Will switch to that.

[vytautas-karpavicius]

GoSDK already have gRPC compatibility layer. I'm planning to switch sys worker on the server side soon.

[longquanzheng]

Sounds great.