Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding mutable state builder tests - adding continue-as-new events #5768

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions common/convert.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ import (
s "github.com/uber/cadence/.gen/go/shared"
)

// Returns a pointer to the given value.
// todo (david.porter) Remove the remaining helpers here which are now obsolete
davidporter-id-au marked this conversation as resolved.
Show resolved Hide resolved
func Ptr[T any](v T) *T {
return &v
}

// IntPtr makes a copy and returns the pointer to an int.
func IntPtr(v int) *int {
return &v
Expand Down
48 changes: 48 additions & 0 deletions common/convert_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
// The MIT License (MIT)

// Copyright (c) 2017-2020 Uber Technologies Inc.

// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in all
// copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.

package common

import (
"testing"

"github.com/stretchr/testify/assert"
)

func TestPtr(t *testing.T) {

aString := "a string"
aStruct := struct{}{}
anInterface := interface{}(nil)

t.Run("a string should be converted to a pointer of a string", func(t *testing.T) {
assert.Equal(t, &aString, Ptr(aString))
})

t.Run("a struct should be converted to a pointer of a string", func(t *testing.T) {
assert.Equal(t, &aStruct, Ptr(aStruct))
})

t.Run("a interface should be converted to a pointer of a string", func(t *testing.T) {
assert.Equal(t, &anInterface, Ptr(anInterface))
})
}
1 change: 1 addition & 0 deletions service/history/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,7 @@ func NewForTestByShardNumber(shardNumber int) *Config {
config.MaxActivityCountDispatchByDomain = dc.GetIntPropertyFilteredByDomain(dynamicconfig.MaxActivityCountDispatchByDomain)
config.EnableCrossClusterOperationsForDomain = dc.GetBoolPropertyFilteredByDomain(dynamicconfig.EnableCrossClusterOperationsForDomain)
config.NormalDecisionScheduleToStartMaxAttempts = dc.GetIntPropertyFilteredByDomain(dynamicconfig.NormalDecisionScheduleToStartMaxAttempts)
config.NormalDecisionScheduleToStartTimeout = dc.GetDurationPropertyFilteredByDomain(dynamicconfig.NormalDecisionScheduleToStartTimeout)
config.PendingActivityValidationEnabled = dc.GetBoolProperty(dynamicconfig.EnablePendingActivityValidation)
config.QueueProcessorEnableGracefulSyncShutdown = dc.GetBoolProperty(dynamicconfig.QueueProcessorEnableGracefulSyncShutdown)
config.QueueProcessorSplitMaxLevel = dc.GetIntProperty(dynamicconfig.QueueProcessorSplitMaxLevel)
Expand Down
1 change: 1 addition & 0 deletions service/history/events/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ func (e *cacheImpl) GetEvent(

e.metricsClient.IncCounter(metrics.EventsCacheGetEventScope, metrics.CacheMissCounter)
event, err := e.getHistoryEventFromStore(ctx, firstEventID, eventID, branchToken, shardID, domainID)

if err != nil {
e.metricsClient.IncCounter(metrics.EventsCacheGetEventScope, metrics.CacheFailures)
e.logger.Error("EventsCache unable to retrieve event from store",
Expand Down
Loading
Loading