Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include stargazers in README.md #5794

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

ibarrajo
Copy link
Contributor

@ibarrajo ibarrajo commented Mar 18, 2024

What changed?
Updated readme with badges and stargazers chart

Why?
Inspired by this readme https://github.com/uber-go/fx/?tab=readme-ov-file

It will be useful to have this metric as s KPI for OSS developer advocacy

How did you test it?
reviewed locally

Potential risks
none

Screenshots

image image

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Merging #5794 (abb3088) into master (dbc5787) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head abb3088 differs from pull request most recent head bd23893. Consider uploading reports for the commit bd23893 to get more accurate results

Additional details and impacted files

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc5787...bd23893. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 18, 2024

Pull Request Test Coverage Report for Build 018e5dcc-5342-4ec7-82c3-42c07aee6740

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 84 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.04%) to 65.141%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 88.06%
common/task/fifo_task_scheduler.go 2 85.57%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/matching/db.go 2 73.23%
common/persistence/executionManager.go 2 78.62%
common/persistence/statsComputer.go 2 95.71%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.18%
service/history/task/fetcher.go 3 85.57%
service/history/task/transfer_standby_task_executor.go 4 85.77%
Totals Coverage Status
Change from base Build 018e5cdf-7f5d-4773-8b9c-ef2d92c714c9: -0.04%
Covered Lines: 95222
Relevant Lines: 146179

💛 - Coveralls

@ibarrajo ibarrajo merged commit b6cfd48 into cadence-workflow:master Mar 20, 2024
18 checks passed
@ibarrajo ibarrajo deleted the starGazers branch May 14, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants