Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write unit tests for remaining functions in cassandra/workflow.go #5818

Conversation

taylanisikdemir
Copy link
Member

What changed?
Write unit tests for remaining functions in cassandra/workflow.go

Why?
Improve coverage

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Merging #5818 (1a0a9f9) into master (4332db6) will increase coverage by 0.18%.
The diff coverage is n/a.

Additional details and impacted files

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4332db6...1a0a9f9. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e784f-ca75-4bf6-93da-dac6fed82742

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 91 unchanged lines in 20 files lost coverage.
  • Overall coverage increased (+0.04%) to 65.269%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.62%
service/history/task/transfer_standby_task_executor.go 2 88.25%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/sql/sqlplugin/postgres/db.go 2 80.0%
service/frontend/api/handler.go 2 62.05%
service/matching/db.go 2 73.23%
service/history/task/transfer_active_task_executor.go 2 72.7%
service/history/execution/mutable_state_util.go 2 78.07%
common/log/tag/tags.go 3 50.18%
Totals Coverage Status
Change from base Build 018e77b5-9d12-41e2-8f94-99b7ce572ebe: 0.04%
Covered Lines: 95383
Relevant Lines: 146139

💛 - Coveralls

@taylanisikdemir taylanisikdemir merged commit b52f1eb into cadence-workflow:master Mar 26, 2024
20 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/workflows_remaining_tests branch March 26, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants