Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit tests for OS client #5836

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

neil-xie
Copy link
Member

@neil-xie neil-xie commented Apr 2, 2024

What changed?
Add more unit tests for OS client

Why?
Improve test coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018e9f90-de56-44a6-8a9f-5f54421157dc

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 51 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.1%) to 65.545%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.62%
service/history/task/transfer_standby_task_executor.go 2 86.6%
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/peerprovider/ringpopprovider/config.go 2 81.58%
service/matching/db.go 2 73.23%
common/util.go 2 91.78%
service/history/task/fetcher.go 2 85.05%
common/persistence/historyManager.go 2 66.67%
common/log/tag/tags.go 3 50.18%
common/task/fifo_task_scheduler.go 3 82.47%
Totals Coverage Status
Change from base Build 018e9d58-6c4d-48f3-914d-eb330d0c7d63: 0.1%
Covered Lines: 95918
Relevant Lines: 146339

💛 - Coveralls

@neil-xie neil-xie merged commit 504e4c8 into cadence-workflow:master Apr 2, 2024
18 checks passed
@neil-xie neil-xie deleted the cdnc_6987_os2_2 branch April 2, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants