Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for cassandra/shard.go #5839

Merged

Conversation

taylanisikdemir
Copy link
Member

What changed?
Added tests for cassandra/shard.go

Why?
Improve coverage

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Merging #5839 (e088ec2) into master (13256e6) will increase coverage by 0.16%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head e088ec2 differs from pull request most recent head fa851cc. Consider uploading reports for the commit fa851cc to get more accurate results

Additional details and impacted files
Files Coverage Δ
...n/persistence/nosql/nosqlplugin/cassandra/shard.go 100.00% <100.00%> (+100.00%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8cb8b...fa851cc. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 2, 2024

Pull Request Test Coverage Report for Build 018ea072-11ff-4c07-aa28-1ba6a7975c95

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 68 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.04%) to 65.57%

Files with Coverage Reduction New Missed Lines %
common/task/parallel_task_processor.go 2 93.06%
common/task/fifo_task_scheduler.go 2 84.54%
service/history/task/transfer_standby_task_executor.go 4 86.19%
service/history/task/fetcher.go 4 86.08%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 12 85.54%
service/history/task/task_util.go 20 70.57%
service/history/execution/mutable_state_task_refresher.go 24 61.08%
Totals Coverage Status
Change from base Build 018ea067-c196-4b9b-885f-9cc9c710a39f: 0.04%
Covered Lines: 95955
Relevant Lines: 146339

💛 - Coveralls

@taylanisikdemir taylanisikdemir enabled auto-merge (squash) April 2, 2024 20:13
@taylanisikdemir taylanisikdemir merged commit bbb7772 into cadence-workflow:master Apr 2, 2024
18 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/shards_tests branch April 2, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants