Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for admin_es_cmds part I #6411

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Conversation

bowenxia
Copy link
Member

@bowenxia bowenxia commented Oct 24, 2024

What changed?

  • Add test for admin_es_cmds part I.
  • Also, when refactoring admin_es_cmds, there are failures in admin_cluster_cmds_test, I've made some refactor in that files as well to not fail tests. But there are some more fmt.println() usages in AdminRebalanceList -> ListWorkflow -> displayPagedWorkflows that needs to be refactored. This change will require workflow_commands_tests.go to be refactored as well. So I'll do this in next PR.

Why?
for a better code coverage

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.40%. Comparing base (a2451be) to head (947b63a).
Report is 3 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
tools/cli/render.go 87.05% <100.00%> (ø)
tools/cli/workflow_commands.go 66.93% <100.00%> (+0.01%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2451be...947b63a. Read the comment docs.

@bowenxia bowenxia merged commit 2947ad3 into master Oct 25, 2024
21 checks passed
@bowenxia bowenxia deleted the xbowen/admin_es_cmds_test_01 branch October 25, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants