Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for reconciliation fetcher #6424

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented Oct 25, 2024

What changed?

  • Added/updated unit tests for reconciliation fetcher folder
  • Renamed some files to snake_case

Why?
Increase coverage

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.96%. Comparing base (01baea8) to head (d2f6d8f).
Report is 1 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
common/persistence/data_manager_interfaces.go 94.91% <ø> (ø)
common/persistence/operation_mode_validator.go 86.22% <ø> (ø)
common/persistence/queue_manager.go 0.00% <ø> (ø)
...ommon/persistence/visibility_manager_interfaces.go 0.00% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01baea8...d2f6d8f. Read the comment docs.

@taylanisikdemir taylanisikdemir force-pushed the taylan/reconciliation_fetcher_tests branch from ab51921 to d2f6d8f Compare October 26, 2024 00:57
@taylanisikdemir taylanisikdemir merged commit 3ee0a10 into cadence-workflow:master Oct 26, 2024
18 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/reconciliation_fetcher_tests branch October 27, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants