Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move frontend handler's client version check to generated code #6425

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Oct 25, 2024

What changed?

  • Move frontend handler version check to generated code
  • This also reverse the order of client version check and shutdown check

Why?
To improve code coverage (57 lines)

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.92%. Comparing base (b8f6da5) to head (ee3db84).
Report is 5 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
service/frontend/api/handler.go 64.89% <ø> (+1.17%) ⬆️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f6da5...ee3db84. Read the comment docs.

@Shaddoll Shaddoll merged commit a79482f into cadence-workflow:master Oct 28, 2024
20 checks passed
@Shaddoll Shaddoll deleted the test2 branch October 28, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants