Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration tests to use grpc #6477

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Nov 4, 2024

What changed?

  • Update integration tests to use grpc
  • Remove nil check for responses with errors (somehow grpc returns empty struct instead of nil for error response)

Why?

  • Tchannel is going to be deprecated
  • We have features only available in grpc

How did you test it?
integration tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.79%. Comparing base (2655dc3) to head (7b57c4a).
Report is 1 commits behind head on master.

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2655dc3...7b57c4a. Read the comment docs.

@Shaddoll Shaddoll force-pushed the grpc branch 2 times, most recently from 7b57c4a to d2a1a80 Compare November 4, 2024 23:00
@Shaddoll Shaddoll merged commit dec9ac9 into cadence-workflow:master Nov 5, 2024
18 checks passed
@Shaddoll Shaddoll deleted the grpc branch November 5, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants