Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for AdminDBScanUnsupportedWorkflow #6478

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented Nov 5, 2024

What changed?
Added test for AdminDBScanUnsupportedWorkflow this makes the coverage of this file 87% (according to goland)

Some error cases are not tested, some are "the os failed" which cannot really be tested.

Why?
Increase coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.18%. Comparing base (221bbc7) to head (4016772).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
tools/cli/admin_db_scan_command.go 50.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
tools/cli/admin_db_scan_command.go 78.82% <50.00%> (+24.70%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 221bbc7...4016772. Read the comment docs.

@jakobht jakobht merged commit a7fa519 into cadence-workflow:master Nov 5, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants