Update CLI to use grpc transport by default #6495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
taylanisikdemir
approved these changes
Nov 13, 2024
dkrotx
added a commit
to dkrotx/cadence-workshop
that referenced
this pull request
Nov 17, 2024
Why?
- Describing aliases is a big part of README.
- Making ./cadence.bat on Windows isn't trivial - you get
cadence.bat.txt by default
- ./cadence.bat doesn't become the same alias as explicit alias for
Linux/Mac - it also requires updating PATH
Also updated cli-command to have `--transport=tchannel` since the default usage is broken
after cadence-workflow/cadence#6495
dkrotx
added a commit
to dkrotx/cadence-workshop
that referenced
this pull request
Nov 17, 2024
Why?
- Describing aliases is a big part of README.
- Making ./cadence.bat on Windows isn't trivial - you get
cadence.bat.txt by default
- ./cadence.bat doesn't become the same alias as explicit alias for
Linux/Mac - it also requires updating PATH
Also updated cli-command to have `--transport=tchannel` since the default usage is broken
after cadence-workflow/cadence#6495
dkrotx
added a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update CLI to use grpc transport by default
Why?
Tchannel is being deprecated
How did you test it?
unit tests, local tests
Potential risks
Release notes
Documentation Changes